search

logstash-plugins / logstash-input-gelf

Apache License 2.0
20 stars 39 forks source link

Use float instead of integer for timestamp parsing to preserve sub-second precision #34

Closed bobrik closed 8 years ago

elasticsearch-release commented 8 years ago

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

jordansissel commented 8 years ago

Is this related to #32?

rikwasmus commented 8 years ago

Fixes same problem (#30 as well BTW) , BigDecimal.frac() might be conserving more precision than casting to float.

bobrik commented 8 years ago

Yes, it's the same thing with simpler code.

colinsurprenant commented 8 years ago

I suggest we adopt #32 with my proposed modifications.

colinsurprenant commented 8 years ago

Thanks @bobrik for your contribution. I will close this PR, the fix in in #35.

bobrik commented 8 years ago

:+1: