Added TCP Support

[iFedix]

You can now use gelf protocol with a TCP connection too. You can choose to use TCP and/or UDP by setting use_tcp and use_udp flags to true or false. You can also choose different ports to listen on (port_tcp and port_udp flags). Note: you can use the same port for TCP and UDP.

Tested with an AWS cloud big setup (lot of aws server instances with nxlog connected to: logstash -> elasticsearch cluster -> kibana). It works!

[monwolf]

I've tested it and it's working with UDP and TCP streams, but if I set use_udp => false into the config file, this change breaks my logstash start

[paladox]

I also tested this locally and works.

Can someone get this merged please? :)

udp dosent seem to work for me but tcp does.

[paladox]

@jsvd hi, im wondering could you review this please? :)

[Hermain]

Can I help getting this merged?

[jsvd]

hi @Hermain, thank you for volunteering! looking at this PR there are few things that need to be done:

1. rebase these commits against master
2. address @paladox points, specially revert the .travis.yml changes and fix udp which seems to have broken with this PR

if you're willing to recreate the PR with these fixes I'll review right away and get this merged and published

[iFedix]

yeah, sorry guys if I am not on this anymore, but I left the job where I used to implement this on their services, so I can't be useful now I guess... Hope I gave at least the point where to start! Cheers

[jsvd]

@iFedix sorry for the time we took to look at this and thank you for the contribution!

[paladox]

Should we create a new pull based on this?

[jsvd]

@paladox Yeah that's the easiest course of action

[Hermain]

I created a pullrequest. I didn't touch the @tcp = nil @udp = nil as I'm a noob in rooby / logstash plugin development and am not 100% sure about the programm flow.

Also I left the stop method untouched because I currently don't understand it, but it works. https://github.com/logstash-plugins/logstash-input-gelf/pull/59

[jsvd]

closing in favor or #59