search

logstash-plugins / logstash-input-google_cloud_storage

Apache License 2.0
4 stars 9 forks source link

Import from gerrit #1

Closed josephlewis42 closed 5 years ago

josephlewis42 commented 6 years ago

Initial PR for a Logstash Google Cloud Storage input. This has general feature parity with our beat which had general feature parity with the LS S3 plugin. Meaning the following major features:

Tagging @rosbo as someone that's reviewed this internally and @erjohnso, @evandbrown as interested parties.

josephlewis42 commented 6 years ago

Friendly ping for status of this PR :-)

josephlewis42 commented 6 years ago

Have you had a chance to take a look at this yet @jsvd?

Thanks!

karenzone commented 5 years ago

@josephlewis42 You did it again. Nice documentation that builds without error right out of the gate. If you think that you might want to link to section headings later, please consider defining the anchors for them now using the format that you're already using ([id="plugins-{type}s-{plugin}-xyz"]).

Thanks for this. It's always a pleasure to work with you.

guyboertje commented 5 years ago

Apologies about the delay.

I'm concerned about the version of Jackson being loaded. In Logstash we currently use 2.9.8

josephlewis42 commented 5 years ago

Hi @guyboertje,

Thank you for the review. I updated the JARs being imported for the GCS client and version is now closer to what LS uses.

I've also removed the line chomp and added new anchors to the documentation like @karenzone recommended (although we don't plan on using them any time soon so they can go out at your convenience).

With that, I bumped the version to 0.10.0.

Let me know what you think. I'm more than happy to port this over to straight Java once Java plugins go GA. I'm super excited about that and the classloader isolation work.

Thanks! - Joseph

evandbrown commented 5 years ago

Hi folks, looks like this failed for LOGSTASH_BRANCH=6.0 && 6.x. Any feedback from the logstash folks would be appreciated. Thanks!

guyboertje commented 5 years ago

@evandbrown We did a mass update of the Travis yaml files on the plugins 2 weeks ago. Here is an example https://github.com/logstash-plugins/logstash-input-kafka/commit/4adfec607d73a6950e8b24996c14744d4883023d I guess you should make the same change.

josephlewis42 commented 5 years ago

Alright, Travis is now updated and is passing.

jsvd commented 5 years ago

A million thanks to all for your code, reviews and patience. Version 0.10.0 has been published https://rubygems.org/gems/logstash-input-google_cloud_storage/versions/0.10.0-java