unpack_gzip_not_working

logstash-plugins / logstash-input-google_cloud_storage

Apache License 2.0

4 stars 9 forks source link

unpack_gzip_not_working #3

Closed claus-strommer-gbl closed 5 years ago

claus-strommer-gbl commented 5 years ago

Fix for https://github.com/logstash-plugins/logstash-input-google_cloud_storage/issues/2

Change gzip? method to use mime type

josephlewis42 commented 5 years ago

Hi @claus-strommer-gbl,

Overall this looks good!

If you do the following I'll cut you a release and push it today otherwise it'll have to wait for tomorrow when I can get this merged then add a new commit and get it approved:

(optional) add your name and/or your company to the CONTRIBUTORS file
bump the .gemspec version to 0.11.0
add an entry in the CHANGELOG for 0.11.0

Thanks! - Joseph

josephlewis42 commented 5 years ago

@claus-strommer-gbl I tested and uploaded. I botched the first upload so it's under version 0.11.1