search

logstash-plugins / logstash-input-google_pubsub

Logstash input for pulling events from Google Pub/Sub service
Apache License 2.0
19 stars 33 forks source link

Skip sending acks if ids are empty #25

Closed josephlewis42 closed 6 years ago

josephlewis42 commented 6 years ago

This is a low-touch fix for #14 where errors are being thrown because Pub/Sub doesn't expect acknowledge requests with an empty array of IDs. If accepted, it will invalidate PRs #22 and #18.

@jakelandis I'm tagging you because you were part of the review for #18

I'm not doing any major refactoring because @rosbo and I are looking at moving this over to the Java API soon to follow suit with logstash-output-google_bigquery and logstash-output-google_cloud_storage.

jakelandis commented 6 years ago

@josephlewis42 LMK if you want me to merge and/or release this.

josephlewis42 commented 6 years ago

@jakelandis that would be great!

josephlewis42 commented 6 years ago

I can close out those other tickets once it's done.

elasticsearch-bot commented 6 years ago

Jake Landis merged this into the following branches!

Branch Commits
master d61bd3c00710aba5577183922a8151b14c176c10
jakelandis commented 6 years ago

This change has been release as 1.0.6

The plugin can be updated with the following command

bin/logstash-plugin update logstash-input-google_pubsub

@josephlewis42 - thanks! , I will let you close out the relevant issues.