On plugin close we should make sure to client.close the HTTP client.
This is esp. important since this plugin uses client.async to fetch requests asynchronously.
The client starts a thread pool for async requests.
NOTE: the client.close operation only closed the internal HTTP client, but since Manticore 0.9.0 it will also close the connection pool and shuts down the (async) executor thread pool.
On plugin close we should make sure to
client.close
the HTTP client. This is esp. important since this plugin usesclient.async
to fetch requests asynchronously. The client starts a thread pool for async requests.NOTE: the
client.close
operation only closed the internal HTTP client, but since Manticore 0.9.0 it will also close the connection pool and shuts down the (async) executor thread pool.CI :red_circle: happens after the unpinning but is likely related to https://github.com/elastic/logstash/issues/13572