logstash-plugins / logstash-input-http_poller

Create Logstash events by polling HTTP endpoints!
https://www.elastic.co/guide/en/logstash/current/plugins-inputs-http_poller.html
Apache License 2.0
43 stars 65 forks source link

Fix: make sure plugin is closing the http client #130

Closed kares closed 2 years ago

kares commented 2 years ago

On plugin close we should make sure to client.close the HTTP client. This is esp. important since this plugin uses client.async to fetch requests asynchronously. The client starts a thread pool for async requests.

NOTE: the client.close operation only closed the internal HTTP client, but since Manticore 0.9.0 it will also close the connection pool and shuts down the (async) executor thread pool.


CI :red_circle: happens after the unpinning but is likely related to https://github.com/elastic/logstash/issues/13572