Add basic test plus some refactors in the plugin side

logstash-plugins / logstash-input-irc

Apache License 2.0

3 stars 16 forks source link

Closed purbon closed 9 years ago

purbon commented 9 years ago

Fixes #12

changes in this PR include:

Add basic tests for the project
Refactor the plugin to include the option to add an option to inject a dummy bot.
Refactor the plugin to have a cleaner shutdown methodology, so the thread is not stuck waiting in the queue if there is no reason.

purbon commented 9 years ago

@guyboertje would really appreciate your thoughts in here. Thanks a lot for your time.

purbon commented 9 years ago

@guyboertje is this in a good shape to be merged? thanks a lot for your time.

guyboertje commented 9 years ago

LGTM

elasticsearch-bot commented 9 years ago

Merged sucessfully into master core-api-v1!