logstash-plugins / logstash-input-jms

12 stars 27 forks source link

JMS Input Plugin improvements #35

Closed robbavey closed 5 years ago

robbavey commented 5 years ago

Adds:

Improves:

DanRoscigno commented 5 years ago

Hi Rob, I had a look at the docs (I am going to write a blog about this input plugin and wanted to see the changes). Thanks for being so thorough. Could I ask for one favor? When you show the logstash conf can you wrap the jms { } section in input { } please? It will reduce any confusion for folks that know JMS, but are new to Logstash.

I will test this out when you merge it, thanks again!

robbavey commented 5 years ago

I can't get the docs to build using either --asciidoc or --asciidoctor. One likely problem is that two headings without content in between doesn't work. I will test to validate before you make those changes.

They could probably do with some explanatory text in there anyway, so I'll add that

The build is also throwing some errors around the callouts. I'm not sure we can repeat the same callout numbers in one example. But again, I will need to test and troubleshoot.

According to this article, it appears that you should be able to, and the numbers get expanded

Let's sync before you make any changes. I'll know more after I do more troubleshooting. Just wanted to update you with what I've learned so far.

Sounds good.

robbavey commented 5 years ago

@karenzone I've reworked the docs a bit to simplify the use of callouts in the asciidoc. The docs should build properly now (famous last words...)