search

logstash-plugins / logstash-input-kafka

Kafka input for Logstash
Apache License 2.0
139 stars 122 forks source link

Added `reconnect_backoff_max_ms` option to set maximum reconnection time... #308

Open arenard opened 5 years ago

arenard commented 5 years ago

...to exponential reconnection backoff

Set default value to reconnect_backoff_ms disable exponential reconnection backoff strategy implemented in kafka client. See : https://github.com/apache/kafka/blob/9a0ea25fee85837748145d37c69cf4d9bb7f9933/clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java#L114

arenard commented 5 years ago

Seen it after but I moved reconnect_backoff_ms option datatype from string to number for coherence with reconnect_backoff_max_ms option.

To avoid two major version changes, it may be better to merge this after: https://github.com/logstash-plugins/logstash-input-kafka/pull/309 because it correct all misleading options datatypes.