Exposing sasl.jaas.config setting

logstash-plugins / logstash-input-kafka

Kafka input for Logstash

Apache License 2.0

139 stars 122 forks source link

Exposing sasl.jaas.config setting #313

Closed vbohata closed 5 years ago

vbohata commented 5 years ago

Simple change which adds sasl_jaas_config allowing to set JAAS per plugin config instead of entire java process. Requested by for example here: https://github.com/logstash-plugins/logstash-input-kafka/issues/203 ...

robbavey commented 5 years ago

@vbohata Apologies for the delay - would you mind rebasing to the latest and resubmitting? This looks just about ready to go

vbohata commented 5 years ago

rebased

robbavey commented 5 years ago

@karenzone Would you mind giving this a look too?

robbavey commented 5 years ago

@vbohata This is good to go - the build issues are an internal issue unrelated to your changes that I will subsequently fix. Once you give me the go ahead, I will merge this patch and publish it shortly afterwards, once I've fixed the CI issues

Thank you for your contribution!

vbohata commented 5 years ago

@robbavey:

Great, you can merge it. Thanks.