search

logstash-plugins / logstash-input-kafka

Kafka input for Logstash
Apache License 2.0
139 stars 122 forks source link

Clarification of behaviour when enable.auto.commit is set to false #333

Closed amitavmohanty01 closed 4 years ago

amitavmohanty01 commented 4 years ago

the behaviour for enable.auto.commit set to false was missing. adding the same to the doc

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

amitavmohanty01 commented 4 years ago

@robbavey , @karenzone I have modified the docs. Hope I understood the feedback correctly. Please take a look.

robbavey commented 4 years ago

@karenzone I'm happy with the change from a technical perspective, if you are OK with it from a doc/formatting side, we can merge this change.

amitavmohanty01 commented 4 years ago

@karenzone I have modified as per your suggestion. Please take a look.