search

logstash-plugins / logstash-input-kinesis

Logstash Plugin for AWS Kinesis Input
Apache License 2.0
45 stars 57 forks source link

Change http proxy config type to password #101

Closed mashhurs closed 1 year ago

mashhurs commented 1 year ago

When running Logstash with --config.debug option, http_proxy config may leak in debug logs. This PR changes http_proxy config type to password to prevent from leaking in the debug logs.

mashhurs commented 1 year ago

This LGTM, but weird that we are setting the whole http_proxy setting as password type, when we should only be masking the password... but I guess we cannot achieve without splitting the two.

Right! We can split it into scheme, host, user and password by introducing new config options. But with this task, I only focused on preventing the leakage. Thank you!