search

logstash-plugins / logstash-input-kinesis

Logstash Plugin for AWS Kinesis Input
Apache License 2.0
45 stars 57 forks source link

updating KCL version to 1.8.10 #36

Open nevins-b opened 6 years ago

nevins-b commented 6 years ago

hmm the failure seems to be the same as logstash-plugins/logstash-input-kafka#241, I'm not sure what the correct fix for this issue

jakelandis commented 6 years ago

@nevins-b - thanks for the contribution. I wouldn't worry about the 5.x failure, it is obviously unrelated to your changes. However, we do prefer independent verification, and I am not personally setup to test this.

Requesting a community member to test this PR

To get this changes on this PR locally:

git clone https://github.com/logstash-plugins/logstash-input-kinesis.git
cd logstash-input-kinesis
curl -s https://patch-diff.githubusercontent.com/raw/logstash-plugins/logstash-input-kinesis/pull/36.patch | git apply

@nevins-b - can you provide detailed instructions for how to test this ?

elasticcla commented 5 years ago

Hi @nevins-b, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?