Open cdenneen opened 8 years ago
My company has a policy of never storing AWS creds in config files, so I just never implemented it. Looks like we should probably implement it for consistency with other plugins, though.
Good question about the plugins list, I'll ask around.
+1 for this. Specifying the creds in the config vs trying to setting them in an env_var hoping the class picks the right ones would be much easier to manage.
@codekitchen any chance you could look at this... from what I can tell it probably only needs a few additions:
https://github.com/logstash-plugins/logstash-input-s3/blob/master/lib/logstash/inputs/s3.rb#L4 https://github.com/logstash-plugins/logstash-input-s3/blob/master/lib/logstash/inputs/s3.rb#L9 https://github.com/logstash-plugins/logstash-input-s3/blob/master/lib/logstash/inputs/s3.rb#L26 https://github.com/logstash-plugins/logstash-input-s3/blob/master/lib/logstash/inputs/s3.rb#L86
and possibly: https://github.com/logstash-plugins/logstash-input-s3/blob/master/lib/logstash/inputs/s3.rb#L20
Think the logstash/plugin_mixins/aws_config should hopefully take care of anything else.
Does this support config options like the rest of the aws plugins do with parameters in the configuration. Seems from the README all other methods are available but this.
Also when will this plugin be added to the logstash plugins list now that it's been added here?
https://www.elastic.co/guide/en/logstash/current/input-plugins.html
Not sure it's necessary but noticed with some other plugins additional creds for the other resources, so different keys for Kinesis, Dynamo, CloudWatch?
Example from: https://github.com/samcday/logstash-output-kinesis/blob/master/README.md