search

logstash-plugins / logstash-input-kinesis

Logstash Plugin for AWS Kinesis Input
Apache License 2.0
45 stars 57 forks source link

Add the support for the WebIdentityTokenCredentialsProvider to run in AWS EKS #76

Closed JPLachance closed 3 years ago

JPLachance commented 4 years ago

Greetings,

This plugin does not run well in Amazon EKS at the moment because it uses an old version of the aws-sdk-java.

Based on https://github.com/aws/aws-sdk-java/issues/2136, the version we need is at least 1.11.717. From that version, the WebIdentityTokenCredentialsProvider credentials provider should be used over the EC2ContainerCredentialsProviderWrapper and the Kinesis input plugin should start running fine in an EKS cluster.

The fix is potentially simple:

Should I open a PR?

Regards, Jean-Philippe

chandrsas commented 4 years ago

Was just about to open a PR for this exact request. I would really appreciate this effort.

JPLachance commented 4 years ago

PR opened. The Travis build is failing. Do we have instructions to install dependencies and run tests locally to debug the issue? I'm not familiar with Ruby and Logstash plugins development.

keatontaylor commented 4 years ago

Would really like to see this PR merged. Will make running logstash in Kubernetes easy.

rdubya16 commented 4 years ago

This is also a blocker for us, any progress on the linked PR?

mike-stewart commented 4 years ago

@jsvd @karenzone @robbavey Any chance either #77 or #80 could be merged?

JPLachance commented 4 years ago

Not until we fix the broken build I guess. I asked for help, I don't know much on Logstash plugins development.

mike-stewart commented 4 years ago

I opened a PR with a passing build and CLA - hopefully that makes it easier to proceed with a release: #82