logstash-plugins / logstash-input-redis

Apache License 2.0
31 stars 69 forks source link

Pin redis dep to 3.x.x since 4.x requires ruby 2+ syntax #59

Closed andrewvc closed 7 years ago

andrewvc commented 7 years ago

This is preventing bundle updates on 5.x series logstashes (using jruby 1.7.x) from working correctly.

Also, we never should have had such a loose version req. It didn't matter till recently since the redis gem was stuck on 3.x for so long.

andrewvc commented 7 years ago

Builds on master and 6.x have failed for a long time. We need to figure that out, but its not related to this patch.

jakelandis commented 7 years ago

LGTM

elasticsearch-bot commented 7 years ago

Andrew Cholakian merged this into the following branches!

Branch Commits
master 19927e7b68a5f058f11a3dbace876ba07c9901b9