search

logstash-plugins / logstash-input-redis

Apache License 2.0
31 stars 69 forks source link

Add support for Redis unix sockets #64

Closed brennentsmith closed 6 years ago

brennentsmith commented 6 years ago

Adds support for unix sockets on connecting to redis. Can result in a 50% increase in performance (https://redis.io/topics/benchmarks) and provides a touch of local ACL’s (permissions on the local file descriptor).

We use Redis heavily at Speedtest.net as a local pre-buffer for logstash, and using unix sockets helps reduce the local overhead.

Corresponding logstash-output-redis PR: https://github.com/logstash-plugins/logstash-output-redis/pull/57

brennentsmith commented 6 years ago

Signed CLA. Rebuild

jordansissel commented 6 years ago

Change looks pretty straight-forward.

I'd like to see mutual exclusion on path vs host and port -- if a user specifies both path and host, Logstash should fail.

jordansissel commented 6 years ago

I'll test this (and your other PR on redis output) tomorrow. Thank you for your work :)

brennentsmith commented 6 years ago

👍 Sounds good on the mutual exclusion - PR updated.

brennentsmith commented 6 years ago

Rebuild. Travis seemed to have a networking issue.

jordansissel commented 6 years ago

I restarted the failed redis job. (3/4 passed, 1 failed due to network issues)

jstoja commented 6 years ago

This is probably mergeable! :)

jsvd commented 6 years ago

@brennentsmith thank you for the contribution, this is great!

brennentsmith commented 6 years ago

@jsvd - logic updated as requested.