Fix invalid feed error and update to 5.0 event api

logstash-plugins / logstash-input-rss

RSS input for Logstash

Apache License 2.0

15 stars 23 forks source link

Closed purbon closed 8 years ago

purbon commented 8 years ago

This PR:

Fixes the case when there is an invalid feed, exceptions are now catched and logged.
Also add test for normal, valid but empty and invalid feeds use cases.
- And updates to use the 5.0 event api.

include code to be using the new logstash-core api, backport will be necessary.

purbon commented 8 years ago

@guyboertje your thoughts here are welcome.

guyboertje commented 8 years ago

@purbon - looks good so far. Please make one of the failure fixtures an atom feed.

purbon commented 8 years ago

@guyboertje can do that, will look for examples.

purbon commented 8 years ago

@guyboertje added atom test as requested, also helped fixing a few issues 👍 , let me know what do you think.

guyboertje commented 8 years ago

LGTM

elasticsearch-bot commented 8 years ago

Pere Urbon-Bayes merged this into the following branches!

Branch	Commits
master	56675d6dc540fe4384078d4a089ef5a3048e4e2e, 49b647496b445cd4963fe019a9dabff9cf1c57a7, 88609d888d252866d6743f4c0640696cdd1d81ea, 1a4fae1377a3167ddc48d2c5e2234882540df131, 10221fa704b6c7621d005227ea227ea9bb9168cd, d9f590935d4a5a7adb04367e64e5020d67df4663