search

logstash-plugins / logstash-input-s3

Apache License 2.0
57 stars 152 forks source link

Add .gzip extension support #113

Closed william0901 closed 7 years ago

william0901 commented 7 years ago

Add .gzip extension support.

jordansissel commented 7 years ago

Code looks good.

I see tests in master that cover .gz files, can you add a test for .gzip as well?

divdevar commented 7 years ago

@william0901 Are you planning to add tests to this PR ?

william0901 commented 7 years ago

@jordansissel @divdevar Sorry, I forgot the test case! Looks like @divdevar created a new pull request with the same code but with test case. Let's use his one then. Closing this instead.