search

logstash-plugins / logstash-input-s3

Apache License 2.0
57 stars 150 forks source link

Symbolize additional_settings hash #149

Closed robbavey closed 6 years ago

robbavey commented 6 years ago

AWS SDK expects symbolized hash keys, so do that.

webmat commented 6 years ago

LGTM.

It looks like something that would be useful to have everywhere. Alternately, it looks like something that may already be available elsewhere ;-)

Could be noted down as a future cleanup if that's the case, though.

robbavey commented 6 years ago

@webmat Thanks for the LGTM

I looked, and we don't have anything in logstash-core AFAICT. I know Rails has symbolize_keys, but we don't use Rails... ;)

elasticsearch-bot commented 6 years ago

Rob Bavey merged this into the following branches!

Branch Commits
master f97e31004838f1c354879d40ea0a2a1348952687
jsvd commented 6 years ago

@robbavey can you do the same for the s3 output https://github.com/logstash-plugins/logstash-output-s3/blob/master/lib/logstash/outputs/s3.rb#L109 ?