search

logstash-plugins / logstash-input-s3

Apache License 2.0
57 stars 150 forks source link

Update documentation to reflect changes to syntax #174

Closed Suhmedoh closed 3 years ago

Suhmedoh commented 5 years ago

Updated to add in a note about syntax changing from version 6.x to 7.x, from double-quote-wrapped keys, to un-quoted keys in the key => value pairs. Added an example of old syntax vs. new for clarity, added a few examples for different keys. I know I ran into an issue with my logstash refusing to process events because it didn't understand settings for the s3 buckets if they were quote wrapped, even though it worked fine in 6.5.4. Hoping this clears up that issue for anyone else who might run into it.

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

kaisecheng commented 3 years ago

Thanks for contributing the doc. We are heading to 8.x and the quotes have been fixed in another PR, hence, close this PR