search

logstash-plugins / logstash-input-s3

Apache License 2.0
57 stars 150 forks source link

Fix example configuration in docs #195

Closed alex-stiff closed 3 years ago

alex-stiff commented 4 years ago

If the keys are quoted as in the previous version of the documentation, this results in errors like this:

[ERROR] 2020-02-21 10:53:27.345 [LogStash::Runner] s3 - Unknown setting '"bucket"' for s3

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

cla-checker-service[bot] commented 4 years ago

💚 CLA has been signed

alex-stiff commented 3 years ago

Thanks for improving our doc. The change looks good. Could you sign the Contributor Agreement to unblock me to merge this PR?

Thanks kaisecheng. I've signed the Contributor Agreement.