Updating aws-sdk to v3 - Githubissues

logstash-plugins / logstash-input-s3

Apache License 2.0

57 stars 150 forks source link

Updating aws-sdk to v3 #210

Closed ageekymonk closed 3 years ago

ageekymonk commented 4 years ago

Fixes #207 . V2 api does not support AWS_WEB_IDENTITY_TOKEN_FILE and AWS_ROLE_ARN value from environment. The fix is to move to v3 api.

kares commented 4 years ago

Thanks ramz, do you know if the 2 versions (aws-sdk v2 + bits of v3) could co exist in one bundle of gems?

dggreenbaum commented 4 years ago

@kares Amazon's readme says that should be ok:

https://github.com/aws/aws-sdk-ruby#upgrading-guide

Version 3 modularizes the monolithic SDK into service specific gems. Aside from gem packaging differences, version 3 interfaces are backwards compatible with version 2.

dominik-ba commented 3 years ago

will this become a new release? :)

ahmedkhattab commented 3 years ago

i still see a Travis CI failed test for ES version 6.x for this merge. Is someone still following up on this to have a release ?