search

logstash-plugins / logstash-input-s3

Apache License 2.0
57 stars 150 forks source link

Fix object timestamp logic #243

Open jniebuhr opened 2 years ago

jniebuhr commented 2 years ago

This should make the s3 input compatible with more S3 compatible backends since the timestamps are taken from the same call. It also changes the logic to something I thought makes more sense. It shouldn't really matter if a file has changed since listing, just if it has changed during downloading/processing. If it had just changed during listing but before the download, the exact same file would be processed twice.

cla-checker-service[bot] commented 2 years ago

💚 CLA has been signed

jniebuhr commented 2 years ago

Anyone got an idea on how to stub this properly? It's been a while writing Ruby :(