search

logstash-plugins / logstash-input-s3

Apache License 2.0
57 stars 150 forks source link

delete comparison issue #240 #246

Closed Derekt2 closed 1 year ago

Derekt2 commented 1 year ago

I'd like to propose these changes that @froheik made in his fork to address https://github.com/logstash-plugins/logstash-input-s3/issues/240

I tested this change and saw zero impacts. The original code seems to have been implemented in 3.6.0 here: https://github.com/logstash-plugins/logstash-input-s3/pull/220

cla-checker-service[bot] commented 1 year ago

❌ Author of the following commits did not sign a Contributor Agreement: c7ffd20ec1678c0cbed686248edb9d1f4b784c52

Please, read and sign the above mentioned agreement if you want to contribute to this project

Derekt2 commented 1 year ago

Closing this as the original author has not signed the contributor agreement and it removes the gemspec. Will open a PR under my name with different changes.

pebosi commented 1 year ago

Any Update? New release planned? Still using the fork from https://discuss.elastic.co/t/s3-input-dont-delete-backup-files-after-processing/299187/2