logstash-plugins / logstash-input-s3

Apache License 2.0
58 stars 152 forks source link

.gzip extension #62

Closed william0901 closed 6 years ago

william0901 commented 8 years ago

logstash-input-s3 currently supports .gz for gzip extension. It makes sense to support .gzip as well.

Will below change work?

https://github.com/logstash-plugins/logstash-input-s3/blob/master/lib/logstash/inputs/s3.rb

from

  private
  def gzip?(filename)
    filename.end_with?('.gz')
  end

to

  private
  def gzip?(filename)
    filename.end_with?('.gz’) || filename.end_with?(‘gzip’)
  end
denmak commented 8 years ago

Hi It would be greate to fix that, because now I have to work this issue around by copying files from one bucket to another, bacause source is third party bucket and I have no permissions to change extentions. many thanks

william0901 commented 7 years ago

Here is the pull request

https://github.com/logstash-plugins/logstash-input-s3/pull/113

yaauie commented 6 years ago

support for the gzip extension was recently merged and released with v3.2.0 of logstash-input-s3:

bin/logstash-plugins update logstash-input-s3