search

logstash-plugins / logstash-input-sqs

Apache License 2.0
16 stars 40 forks source link

Add queue_owner_aws_account_id #60

Closed theredcat closed 2 years ago

theredcat commented 2 years ago

Hello !

This PR is basically a copy of #38 by @majjacz with @ph remarks implemented.

It allow to use a queue shared between two AWS accounts that have been configured with SQS embed access policies instead of an IAM role using the queue_owner_aws_account_id option

theredcat commented 2 years ago

@jsvd I tagged PH on this issue but it seem that you are the new maintainer of this plugin. Could you take a look at this ?

theredcat commented 2 years ago

Thank you for the contribution, I've left a few comments, similar to those in #38. If you can, please include a minor version bump (major.minor.patch) and a new entry in the changelog.md so we can publish it after the changes.

@jsvd That's done. I've bumped from 3.1.3 to 3.2.0 since this is a new feature. I hope that was the right thing to do ?

jsvd commented 2 years ago

@theredcat thank you for the contribution and iterations, this change has been published in 3.2.0 https://rubygems.org/gems/logstash-input-sqs/versions/3.2.0