search

logstash-plugins / logstash-input-syslog

Apache License 2.0
37 stars 38 forks source link

Fix the reload crash reported by https://github.com/logstash-plugins/… #41

Closed craig-miskell-fluxfederation closed 4 years ago

craig-miskell-fluxfederation commented 6 years ago

…logstash-input-syslog/issues/40

nerophon commented 6 years ago

@ph can you help out here? Do you know why the CI rejected this? Another user has hit the issue this claims to fix, so it'd be cool to get it in if it works :)

jsvd commented 6 years ago

The issue #40 mentions of the plugin raising an IOError, but this PR catches Errno::EBADF. These two have different class hierarchies and I don't see a clear path where we can one and throw the other, so I'm not convinced this fixes the issue.

 :001 > Errno::EBADF.ancestors
 => [Errno::EBADF, SystemCallError, StandardError, Exception, Object, Kernel, BasicObject] 
 :002 > IOError.ancestors
 => [IOError, StandardError, Exception, Object, Kernel, BasicObject]
nerophon commented 6 years ago

Alright, let's circle back to the issue.

kares commented 4 years ago

this is now a defunct PR (due #43) ... thanks for all the efforts :evergreen_tree: