search

logstash-plugins / logstash-input-syslog

Apache License 2.0
37 stars 38 forks source link

Refactor: avoid global side-effect + cleanup #62

Closed kares closed 4 years ago

kares commented 4 years ago

What does this PR do?

This is mostly a (low-risk) code cleanup effort to improve the code-base.

Why is it important?

Plugins should not have global side effects that could influence other plugins or LS behavior. Also, ideally plugins should not use deprecated test dependencies. Last but not least this code improves exception logging format - aligns with the same conventions as used elsewhere.

roaksoax commented 4 years ago

@jsvd @kares have issues been filed for the other plugins to address the issue with BasicSocket.do_not_reverse_lookup ?

roaksoax commented 4 years ago

also, reading this PR doesn't explain WHY we are making changes. We need to do this.

kares commented 4 years ago

@roaksoax sorry about that. context: here was to start with a cleaner code-base (for followups). I updated the description but there isn't much on "why" for a refactoring except for 'cleaner' code.