search

logstash-plugins / logstash-input-udp

Apache License 2.0
13 stars 22 forks source link

fix performance regression calling IO.select for every packet #26

Closed IrlJidel closed 8 years ago

IrlJidel commented 8 years ago

Fixes #21

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

clintongormley commented 8 years ago

@jsvd the CLA is now signed

jsvd commented 8 years ago

I will do a small amount of manual testing today or tomorrow morning and if all's good I'll merge it tomorrow. Thanks for the work @IrlJidel :)

IrlJidel commented 8 years ago

@jsvd Any issues found during testing?

jsvd commented 8 years ago

@IrlJidel awesome PR, nice speed boost (14k eps to 24k eps on my laptop) and all seems good 👍 LGTM

elasticsearch-bot commented 8 years ago

João Duarte merged this into the following branches!

Branch Commits
master a65a585ec3203332d7329b482ade04f9f5f75628
jsvd commented 8 years ago

Version 3.0.3 has been released with this patch :+1:

On Thu, Oct 13, 2016, 14:26 J.A.R.V.I.S. - an Elastic git bot. < notifications@github.com> wrote:

Closed #26 https://github.com/logstash-plugins/logstash-input-udp/pull/26 via a65a585 https://github.com/logstash-plugins/logstash-input-udp/commit/a65a585ec3203332d7329b482ade04f9f5f75628 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/logstash-plugins/logstash-input-udp/pull/26#event-822472877, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB8QWzciJpJqZNuoc2xkOmqCGZ4SLH7ks5qzjFwgaJpZM4JuDCZ .