search

logstash-plugins / logstash-input-websocket

Apache License 2.0
13 stars 18 forks source link

logstash 5.2.0 support #15

Closed alancnet closed 5 years ago

alancnet commented 7 years ago

No text

magnusbaeck commented 7 years ago

@alancnet, could you please elaborate? As of #14 (included in v4.0.0) the plugin is 5.x compatible and I'm not aware of any problems with Logstash 5.2.

pvdvreede commented 7 years ago

I have had an issue with gem version incompatibilities. ftw is using addressable 2.2 but logstash somewhere requires 2.3.8.

I have done a PR to ftw to try and fix this (see https://github.com/jordansissel/ruby-ftw/pull/36), but I am not sure if something can be done here to get around this issue?

alancnet commented 7 years ago

@pvdvreede That may very well solve the issue I was having.. I'll try to confirm soon. Thank you

magnusbaeck commented 7 years ago

So the problem is that the ftw library needed by this plugin requires 2.2.x of the addressable library, but other Logstash plugins require 2.3.x. The PR filed by @pvdvreede (jordansissel/ruby-ftw#36) attempts to address this, and when merged and included in a new ftw release we can bump the required version of ftw and release a new logstash-input-websocket.

moshe-sa commented 7 years ago

Any update?

magnusbaeck commented 7 years ago

@moshe-sa, as indicated in my comment a few days ago this issue won't move until the referenced ruby-ftw PR is resolved.

magnusbaeck commented 5 years ago

The PR quoted above is still unmerged but an equivalent PR, https://github.com/jordansissel/ruby-ftw/pull/38, has been merged and I've been able to install this plugin in various Logstash releases, including the currently latest one (6.6.1).

I'm therefore closing this issue since the specific points raised have been addressed, but do note issue #19 which describes the exact same class of problem but for Logstash 7.0, currently in beta.