Remove mentions of the non-existent server mode

logstash-plugins / logstash-input-websocket

Apache License 2.0

13 stars 18 forks source link

Remove mentions of the non-existent server mode #9

Closed magnusbaeck closed 8 years ago

magnusbaeck commented 8 years ago

@logstash-plugins/logstash-core, please review.

elasticsearch-release commented 8 years ago

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

magnusbaeck commented 8 years ago

Jenkins, test it.

purbon commented 8 years ago

please jenkins, test it.

purbon commented 8 years ago

@magnusbaeck the change looks reasonable to me. Can you raise the major version, as this changes the public api and add the change to the changelog? thanks man

magnusbaeck commented 8 years ago

please jenkins, test it.

Was I not polite enough for the bot or is it only core folks that can ask for a Jenkins run?

Can you raise the major version, as this changes the public api and add the change to the changelog?

Sure. Do you usually step the version and add a changelog entry in a separate commit or in the same commit that drives the version bump?

purbon commented 8 years ago

re jenkins, you were polite enough, was a configuration issue that is fix now. Next time if you ask please jenkins, test it it will run.

re changelog: I usually do all in one commit, but this is your call at the end of the day.

magnusbaeck commented 8 years ago

re changelog: I usually do all in one commit, but this is your call at the end of the day.

Okay, I amended the previous commit. Please have another look.

purbon commented 8 years ago

LGTM

elasticsearch-bot commented 8 years ago

Pere Urbon merged this into the following branches!

Branch	Commits
master	72a0586fd6bf211d264260702062a981702f4c3a

purbon commented 8 years ago

@magnusbaeck are you considering backporting to the 1.x branch?

magnusbaeck commented 8 years ago

are you considering backporting to the 1.x branch?

1.x branch of Logstash? Will there be any more releases to speak?

purbon commented 8 years ago

sorry, core-api-v1 branch of this plugin, this match 1.x logstashes. It does not matter at if we do more releases or not, but users could want to fetch plugin improvements while not updating their logstash.

magnusbaeck commented 8 years ago

Okay, fair point. So we'd bump the version from 0.1.x to 1.0.x then I guess? And hope we won't have to bump the major version on that branch ever again? :-)

purbon commented 8 years ago

@magnusbaeck I know, is a problem .... you know, versions and cross version support is always complicated. Do you know anything that might help on this? proposals welcome for sure.