logstash-plugins / logstash-integration-rabbitmq

Logstash Integration Plugin for RabbitMQ, including Logstash Input and Output Plugins
Apache License 2.0
5 stars 25 forks source link

input: add support for extended metadata #14

Closed yaauie closed 4 years ago

yaauie commented 4 years ago

This is a Work-In-Progress solution for https://github.com/logstash-plugins/logstash-integration-rabbitmq/issues/13, in which a user has a need for the raw payload.

Since raw payload metadata drastically increases the size of in-flight events, I wanted to implement this in a way that would only incur that overhead for people who explicitly need raw payloads.

To do this, I changed the formerly boolean metadata_enabled to instead accept a value from a list:

Needs tests, but hoping for validation of concept before I dive in.

andsel commented 4 years ago

Hi @yaauie to me seems good, I would add just a couple of tests to avoid regression.

andsel commented 4 years ago

LGTM