search

logstash-plugins / logstash-integration-snmp

Logstash Integration Plugin for SNMP, including SNMP input and SNMP Trap Plugins
Apache License 2.0
0 stars 3 forks source link

Doc: Add snmp and snmptrap migration guides #14

Closed edmocosta closed 4 months ago

edmocosta commented 4 months ago

Closes: https://github.com/logstash-plugins/logstash-integration-snmp/issues/11

karenzone commented 4 months ago

As you know, we're not generating these files yet. I'm testing locally and I also mocked up this PR as a testbed: https://github.com/elastic/logstash-docs/pull/1629. I can explain in more detail if you're interested.

edmocosta commented 4 months ago

From my local build: WARNING: ../../logstash-docs/docs/plugins/inputs/snmp.asciidoc: line 403: id assigned to section already in use: plugins-inputs-snmp-use_provided_mibs

The section and id for use_provided_mibs is duplicated starting at lines 337 and 403. If you want this option to appear in both places, you'll need to give the second occurrence a different id.

I'll do a more thorough review after we clear the docs build issues.

Hey @karenzone, thanks for reviewing! It was indeed duplicated.

karenzone commented 4 months ago

@edmocosta, I'm still working on structure and asciidoctor format for the idea that we discussed. I'll have something for you to look at tomrrow.

edmocosta commented 4 months ago

Closed by: https://github.com/logstash-plugins/logstash-integration-snmp/pull/15