logstash-plugins / logstash-output-datadog_metrics

Apache License 2.0
3 stars 16 forks source link

use new Json and Timestamp API #1

Closed colinsurprenant closed 9 years ago

jim80net commented 9 years ago

This would resolve this problem, where to_epoch is attempting to parse a LogStash::Timestamp.

NoMethodError: undefined method `gsub!' for "2015-05-28T22:46:35.392Z":LogStash::Timestamp
         _parse at /var/vcap/data/packages/logstash/cd5c01a51429653cc4b8cbc89d423857149f4cea.1/logstash/vendor/jruby/lib/ruby/1.9/date/format.rb:839
          parse at /var/vcap/data/packages/logstash/cd5c01a51429653cc4b8cbc89d423857149f4cea.1/logstash/vendor/jruby/lib/ruby/1.9/time.rb:265
       to_epoch at /var/vcap/packages/logstash/logstash/vendor/local_gems/ee2af373/logstash-output-datadog_metrics-0.1.4/lib/logstash/outputs/datadog_metrics.rb:120
        receive at /var/vcap/packages/logstash/logstash/vendor/local_gems/ee2af373/logstash-output-datadog_metrics-0.1.4/lib/logstash/outputs/datadog_metrics.rb:75
         handle at /var/vcap/packages/logstash/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.0-java/lib/logstash/outputs/base.rb:88
    output_func at (eval):215
   outputworker at /var/vcap/packages/logstash/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.0-java/lib/logstash/pipeline.rb:244
  start_outputs at /var/vcap/packages/logstash/logstash/vendor/bundle/jruby/1.9/gems/logstash-core-1.5.0-java/lib/logstash/pipeline.rb:166
jim80net commented 9 years ago

same issue as described here: https://github.com/logstash-plugins/logstash-output-influxdb/commit/9062dda54ffcf4910c85ae1e8426861094508945

devinrsmith commented 9 years ago

+1

guyboertje commented 9 years ago

I am going to combine this #1 and #4 in one new PR with tests.

purbon commented 9 years ago

@guyboertje should we close this PR, as you combined #1 and #4 in #5 ? I guess makes sense to move all discussion there, right? what do you think?

guyboertje commented 9 years ago

As PR #5 is now merged - I am closing this one