search

logstash-plugins / logstash-output-datadog_metrics

Apache License 2.0
3 stars 16 forks source link

Adds config for api_url for eu users and update docs #13

Closed ericmustin closed 1 month ago

ericmustin commented 5 years ago

This PR adds @api_url as a config available in LogStash::Outputs::DatadogMetrics , as Datadog now has users in the EU region which have a different API endpoint than the US region. This will continue to grow to new regions in the future and this url should be configurable going forward.

The config option keeps the default as the US API Endpoint, but allows EU users to update to the EU endpoint in their config with a config such as

output {
  datadog_metrics {
      api_key => "..."
      api_url => "https://api.datadoghq.eu/api/v1/series"
      metric_name => 'response_time'
      metric_type => "counter"
      metric_value => "1"
  }
}

Also the US API endpoint currently being used ("https://app.datadoghq.com/api/v1/series") is deprecated and while it will work for now it's best to also move this over to the new endpoint ("https://api.datadoghq.com/api/v1/series") . For reference see Datadog Documentation

Also includes a Docs update

ericmustin commented 5 years ago

@yaauie thanks for taking a look, made the changes you suggested and filled out the CLA, thanks again for the quick turn around here much appreciated!

felixb commented 4 years ago

Any news on this PR?

LuigiClemente-Awin commented 2 years ago

Really? We cannot use the plugin in Europe...

mashhurs commented 2 months ago

Can you please

Thank you!

ericmustin commented 2 months ago

@mashhurs

It's been 6 years since I made this PR.

It would be hilarious though if we could get it merged.

For that reason, and solely that reason, I will try to fix up those changes you requested this evening.

ericmustin commented 1 month ago

updated with pr feedback. lmk if anything else needed here @mashhurs !

mashhurs commented 1 month ago

Published v3.0.6