EU Datadog Users can't update api url endpoint

ericmustin commented 5 years ago

Hi there, Datadog has an EU region now which has a different url for the API Endpoint here in datadog_metrics.rb, however the US API endpoint is hardcoded into this plugin. Further the API Endpoint hardcoded in here has been deprecated ( in favor of https://api.datadoghq.com/api/v1/series as seen in Datadog Docs here. Given that there will likely be new regions in the future I was hoping to be able to make this url instance variable configurable

I made a quick PR that outlined these changes if anyone could take a look or wants to run with it or has feedback, I would be happy to make any suggested changes or feedback

https://github.com/logstash-plugins/logstash-output-datadog_metrics/pull/13

(I signed the CLA but that check is failing for some reason, and oddly the test suite is failing for reasons that look unrelated to my change)

Thanks for taking a look! -Eric

ericmustin commented 5 years ago

@yaauie heyy wasn't sure who the maintainers are on this / no codeowners file in the plugin folder, but you seem to be the poor soul still active on this repo so pinging just to ask if you're the right person to touch base with on the above? Apologies for the annoyance

yaauie commented 5 years ago

@ericmustin I would be glad to take a look, but it might be a couple days before I can get to it.

ericmustin commented 5 years ago

@yaauie ty kindly, much appreciated, and yes definitely no stress/rush i appreciate the work you're doing on this in general so whenever your schedule permits. all the best.