search

logstash-plugins / logstash-output-elastic_app_search

Apache License 2.0
0 stars 9 forks source link

Changed evaluation of 'engine' to sustain sprintf format #25

Closed andsel closed 3 years ago

andsel commented 3 years ago

If 'engine' contains a sprintf formatter markes (%{}) then the check_connection is avoided and the engine is selected on an eventby event basis.

This changed the way the batch update is done, now instead of a document list, the documents are partitioned by engine (once resolved by event's sprintf) and then indexed by each parition.

Fixes #22

andsel commented 3 years ago

The failures are not related to the changes:

robbavey commented 3 years ago

@andsel wrt https://github.com/logstash-plugins/logstash-output-elastic_app_search/pull/25#issuecomment-801913479, this is going to fail on all stack versions 7.11.0 and above, given the removal of oss artifacts because of this line If we want to keep the oss integration tests against the stack, we will need to pin to 7.10.2

andsel commented 3 years ago

@robbavey as I know enterprise-search-oss never existed, so we could remove the oss part. What we miss is the test of the plugin with an OSS Logstash.

andsel commented 3 years ago

@robbavey about:

do we know why the tests fail on SNAPSHOT builds?

The answer is yes, we 2 kind of failures:

karenzone commented 3 years ago

@andsel Thanks for alerting me about this PR. I see that @robbavey has suggested some docs changes. I see a few more items that need attention, but layering docs changes on to of other docs changes can get confusing. Please let me know when you've resolved his comments, and I'll do a quick final docs review. Thanks for the heads up

andsel commented 3 years ago

@karenzone I've applied Rob's suggestions to docs, so now you can go

andsel commented 3 years ago

Thanks @karenzone for the really fluent rewording of the engine resolution meaning