logstash-plugins / logstash-output-elastic_app_search

Apache License 2.0
0 stars 9 forks source link

Correct typo, AppSearch -> App Search #28

Closed richkuz closed 3 years ago

richkuz commented 3 years ago

Trivial change to fix capitalization of App Search in a heading.

richkuz commented 3 years ago

@jsvd would you be willing to review and merge this small doc change? Also, I am not sure how to fix the CI failure.

jsvd commented 3 years ago

@andsel since we moved this to an integration plugin, can you fix it this typo there instead (and see if there are other instances of the same typo?

andsel commented 3 years ago

@jsvd fixes ported to the integration plugin https://github.com/logstash-plugins/logstash-integration-elastic_enterprise_search/pull/9 @richkuz the fail on 8.0.0-SNAPSHOT is something "expected" because EnterpriseSearch 8.0.0 is a link to the latest 7.x and the EnterpriseSearch 7.x expects to work with Elasticsearch 7.x

richkuz commented 3 years ago

Thanks! I'll close this PR then in favor of the more comprehensive PR opened in the integration plugin, https://github.com/logstash-plugins/logstash-integration-elastic_enterprise_search/pull/9