search

logstash-plugins / logstash-output-elastic_app_search

Apache License 2.0
0 stars 9 forks source link

add support for self-managed app search #6

Closed jsvd closed 5 years ago

jsvd commented 5 years ago

replaces https://github.com/logstash-plugins/logstash-output-appsearch/pull/9

fixes #4

jsvd commented 5 years ago

@peterskim12 hi! I've performed the changes and tested both locally against self managed 0.1.0-beta5 and saas app search instances. what do you think?

jsvd commented 5 years ago

my reason to expect only part of the URL on the url parameter is that when you use on prem app search the UI gives you the endpoint to use and has a "copy" url button, that only copies http://localhost:port, it doesn't copy the rest of the url. I also added path more as future proof setting, so that folks can change from /api/as/v1 to something else if necessary.

I'll improve the error handling so that using host + path returns an error.

jsvd commented 5 years ago

hi @yaauie, can you give me a final lgtm? I think all concerns have been addressed, thanks for the review 👍