search

logstash-plugins / logstash-output-elasticsearch

https://www.elastic.co/guide/en/logstash/current/plugins-outputs-elasticsearch.html
Apache License 2.0
216 stars 306 forks source link

Replace document_already_exist_exception with version_conflict_engine_exception in the silence_errors_in_log setting example #1159

Closed herrBez closed 8 months ago

herrBez commented 8 months ago

The example reported in documentation for the setting silence_errors_in_log does not appear to work with modern version of Elasticsearch. The correct value should be version_conflict_engine_exception, which as per https://github.com/elastic/elasticsearch/blob/main/server/src/main/java/org/elasticsearch/ElasticsearchException.java#L1271C1-L1272C replaced the exception document_already_exist_exception.

This PR replace in the example for silence_errors_in_log the deprecated/not more existent document_already_exist_exception with the value version_conflict_engine_exception.

cla-checker-service[bot] commented 8 months ago

💚 CLA has been signed

kaisecheng commented 8 months ago

@logstashmachine bump patch

kaisecheng commented 8 months ago

The changes look good. Please bump the version to 11.20.1 in CHANGELOG.md and logstash-output-elasticsearch.gemspec. Could you sign the contributor agreement?