logstash-plugins / logstash-output-elasticsearch

https://www.elastic.co/guide/en/logstash/current/plugins-outputs-elasticsearch.html
Apache License 2.0
218 stars 305 forks source link

Unable to bootstrap the master branch #53

Closed purbon closed 9 years ago

purbon commented 9 years ago

Hi, if you start from a fresh master branch and run the bundle command it hangs while trying to fetch/installing manticore 0.3.4:

Installing sinatra 1.4.5
Installing stud 0.0.19
Installing polyglot 0.3.5
Installing treetop 1.4.15
Using logstash 1.5.0.beta1 from git://github.com/elasticsearch/logstash.git (at 1.5)
Installing logstash-codec-plain 0.1.4
Installing logstash-input-generator 0.1.2
Installing manticore 0.3.4

this basically makes impossible to build this master branch.

purbon commented 9 years ago

While trying to fix https://github.com/logstash-plugins/logstash-input-kafka/pull/22 and then applying the same idea here I encountered the next:

➜  logstash-output-elasticsearch git:(fix/jar-dependency) ✗ bundle exec rspec          
Using Accessor#strict_set for specs
LoadError: no such file to load -- logstash-output-elasticsearch_jars
          require at org/jruby/RubyKernel.java:1065
          require at /Users/purbon/.rvm/gems/jruby-1.7.16.1@logstash-out-es/gems/polyglot-0.3.5/lib/polyglot.rb:65
           (root) at /Users/purbon/work/plugins/outputs/logstash-output-elasticsearch/lib/logstash/outputs/elasticsearch.rb:11
          require at org/jruby/RubyKernel.java:1065

This are the changes I did:

   s.add_runtime_dependency 'logstash', '>= 1.4.0', '< 2.0.0'
-  s.add_runtime_dependency 'jar-dependencies'

   s.add_development_dependency 'ftw', '~> 0.0.42'
   s.add_development_dependency 'logstash-input-generator'
@@ -37,6 +36,7 @@ Gem::Specification.new do |s|
   if RUBY_PLATFORM == 'java'
     s.platform = RUBY_PLATFORM
     s.add_runtime_dependency "manticore", '~> 0.3'
+    s.add_development_dependency 'ruby-maven', '3.1.1.0.8'
   end

making sure to use logstash-devutils (https://github.com/elasticsearch/logstash-devutils/pull/20) that install jar-dependencies and ruby-maven properly.

talevy commented 9 years ago

fixed by: https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/56