Closed andrewvc closed 9 years ago
Meta question - is spec.unit
a directory pattern we want to use going forward?
@jordansissel that is a mistake, no idea how I put that in there, will back out that change.
@jordansissel removed the dir. Thanks for catching that
@talevy would either of you mind taking a look at this change set? I just backported the latest stuff around upserting.
This also pulls https://github.com/elastic/logstash/issues/3735 (jar dependencies) via cherry pick
This is currently broken pending https://github.com/mkristian/jar-dependencies/issues/26 (figure out how to get the jar deps working)
Should there be all those .jar files checked into git? Seems like a recipe for fast git repo size growth. Thoughts?
Finished reviewing the code, but didn't review the specs yet. Left a few comments.
I'll run the tests soon and report back. :)
@andrewvc is network_host
required for both protocols? I tried beta3 with transport and it worked with only hosts
setting. I was running ES and LS on localhost though :)
@suyograo this must be an ES2.0 change, because it just won't join the cluster without that set.
We could do some detection by attempting to get the hostname (which usually works for AWS), but it's probably best to just make it explicit.
@andrewvc lets make it explicit for now.
i tested this PR and it works for both transport and node
LGTM :)
Removal of HTTP stuff