logstash-plugins / logstash-output-elasticsearch_java

Java API Implementation of Elasticsearch Output
Apache License 2.0
0 stars 8 forks source link

Native only #1

Closed andrewvc closed 9 years ago

andrewvc commented 9 years ago

Removal of HTTP stuff

jordansissel commented 9 years ago

Meta question - is spec.unit a directory pattern we want to use going forward?

andrewvc commented 9 years ago

@jordansissel that is a mistake, no idea how I put that in there, will back out that change.

andrewvc commented 9 years ago

@jordansissel removed the dir. Thanks for catching that

andrewvc commented 9 years ago

@talevy would either of you mind taking a look at this change set? I just backported the latest stuff around upserting.

andrewvc commented 9 years ago

This also pulls https://github.com/elastic/logstash/issues/3735 (jar dependencies) via cherry pick

andrewvc commented 9 years ago

This is currently broken pending https://github.com/mkristian/jar-dependencies/issues/26 (figure out how to get the jar deps working)

jordansissel commented 9 years ago

Should there be all those .jar files checked into git? Seems like a recipe for fast git repo size growth. Thoughts?

jordansissel commented 9 years ago

Finished reviewing the code, but didn't review the specs yet. Left a few comments.

I'll run the tests soon and report back. :)

suyograo commented 9 years ago

@andrewvc is network_host required for both protocols? I tried beta3 with transport and it worked with only hosts setting. I was running ES and LS on localhost though :)

andrewvc commented 9 years ago

@suyograo this must be an ES2.0 change, because it just won't join the cluster without that set.

We could do some detection by attempting to get the hostname (which usually works for AWS), but it's probably best to just make it explicit.

suyograo commented 9 years ago

@andrewvc lets make it explicit for now.

suyograo commented 9 years ago

i tested this PR and it works for both transport and node

jordansissel commented 9 years ago

LGTM :)