search

logstash-plugins / logstash-output-elasticsearch_java

Java API Implementation of Elasticsearch Output
Apache License 2.0
0 stars 8 forks source link

Add statement about elasticsearch_java not being supported #45

Closed dedemorton closed 7 years ago

dedemorton commented 8 years ago

Fixes issue #43

acchen97 commented 8 years ago

@dedemorton I had actually intended that message to go in the note itself. The current note saying its "easy to install" is misleading since the install is broken.

dedemorton commented 8 years ago

@acchen97 That note is boiler plate text that gets added as part of the docgen process. I don't think we can alter it without altering the note in all the other plugins. @suyograo would know for sure if it's possible to remove the note: "This is a community-maintained plugin! It does not ship with Logstash by default, but it is easy to install by running bin/logstash-plugin install logstash-filter-translate."

acchen97 commented 8 years ago

My best guess would be its alterable, as the note in elasticsearch_java is already different from the others.

dedemorton commented 8 years ago

Ohhhh...good point. I'll dig into more and change it.

dedemorton commented 8 years ago

@suyograo So it looks like we tweaked the asciidoc to change this statement. Not sure that is a good practice because these changes will be lost when we generate the asciidoc again. Or is this doc static now? Let me know. I def have reservations about tweaking the asciidoc with changes that aren't also made in the source files.

suyograo commented 7 years ago

We should remove the documentation for this plugin altogether. there is no need to add a banner to this.

dedemorton commented 7 years ago

Closing this PR in favor of removing the docs entirely in https://github.com/elastic/logstash-docs/pull/339