search

logstash-plugins / logstash-output-file

Apache License 2.0
23 stars 53 forks source link

Backport/fix when file is gone #22

Open purbon opened 9 years ago

purbon commented 9 years ago

Backport #21, notice a few things need to do to make the backport compatible.

for the rest the backport is good and working. please check #21 and #20 if you need more clarifications to what this changes are doing.

Fixes #20 for 1.x plugins.

colinsurprenant commented 9 years ago

@purbon as discussed in elastic/logstash#4236 and elastic/logstash#4188 having these versions in the gemspec is not the correct solution. for now I suggest you just put these in the main Gemfile of the plugin and not touch the gemspec until we figure the right strategy.

purbon commented 8 years ago

@colinsurprenant @jordansissel or @ph can one of you please validate this and give me your opinion. thanks a lot.

colinsurprenant commented 8 years ago

@purbon I don't think we need to push a new Gemfile version? Why not just put the < 1.999.0 in the gemspec?

purbon commented 8 years ago

@colinsurprenant sorry, still not agreed that 1.999.0 is the prefered way to go vs using 2.0.0.a, at less that I understand.

purbon commented 8 years ago

@colinsurprenant I pushed the gemfile because I understood is necessary to let this plugin work for now, right? I do really would like to unblock the backport and agree on a way to go.

colinsurprenant commented 8 years ago

@purbon the Gemfile is only necessary for local development work.

updated elastic/logstash#4236 to try and explain my point of view. think about it.

purbon commented 8 years ago

@colinsurprenant I made the changes as discussed. I keep the Gemfile with the concurrent ruby fix as is required for dev env to not be broken. let me know what do you think?