Fix wrong gem require - Githubissues

logstash-plugins / logstash-output-graphite

Apache License 2.0

9 stars 15 forks source link

Fix wrong gem require #2

Closed purbon closed 9 years ago

purbon commented 9 years ago

Fix mocha as a dependency require on the specs. , otherwise they are not being executed and fail.

jsvd commented 9 years ago

there are tons of problems w/ the tests in this plugin, raised in #1

missing logstash plugins kv and generator for development
running bundle exec rspec -t socket --order default halts at some point probably trying to send events to a closed port or something
I think some tests are order dependent, need more info..

this pr might be a place to fix this stuff

purbon commented 9 years ago

@jsvd This is awesome, but we need to fix that in a new PR. For now we just need to fix the dependency and be able to run all test together.

can we merge this and fix the test in another PR?

purbon commented 9 years ago

@jsvd refactored and fixed the test after also @electrical requested. now they run properly, next step is to be sure they are testing what mathers :+1:

electrical commented 9 years ago

LGTM

jsvd commented 9 years ago

LGTM

elasticsearch-bot commented 9 years ago

Merged sucessfully into master!

ph commented 9 years ago

Yes :heart_eyes: