search

logstash-plugins / logstash-output-http

Apache License 2.0
35 stars 82 forks source link

Update automatic_retries description #104

Closed sonnhotani closed 4 years ago

sonnhotani commented 5 years ago

I found that there is a conflict between description of automatic_retries and retry_non_idempotent. automatic_retries: if retry_non_idempotent is set only GET, HEAD, PUT, DELETE, OPTIONS, and TRACE requests will be retried. https://www.elastic.co/guide/en/logstash/current/plugins-outputs-http.html#plugins-outputs-http-automatic_retries

retry_non_idempotent If automatic_retries is enabled this will cause non-idempotent HTTP verbs (such as POST) to be retried. https://www.elastic.co/guide/en/logstash/current/plugins-outputs-http.html#plugins-outputs-http-retry_non_idempotent

=> It should be: if retry_non_idempotent is NOT set only GET, HEAD, PUT, DELETE, OPTIONS, and TRACE requests will be retried.

ftatard commented 5 years ago

Good catch ! I've been confused when reading the doc too. Can we get this merged ?