Open brupm opened 9 years ago
Code seems OK, but I have no experience with influxdb, so I'm not sure how to test. Also missing tests as @suyograo mentioned.
@brupm Can you work on this?
I really want to. I've been meaning to spend some time finishing up these PRs but work's been taking up all of my time. Give a couple weeks.
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.
@brupm is there any way to add tests, even using mocks?
Also this is an extension from this PR right? https://github.com/logstash-plugins/logstash-output-influxdb/pull/11