search

logstash-plugins / logstash-output-influxdb

Apache License 2.0
58 stars 79 forks source link

Fix issue #22 #27

Closed albanf closed 8 years ago

albanf commented 9 years ago

Fix issue #22 and add time precisions supported by InfluxDB 0.9

purbon commented 9 years ago

Thanks a lot for your contribution @albanf, it would be super nice if you can add test for this change. We try to enforce that all PR introduce some kind of testing, so we're able to increase the overall quality. Don't hesitate to ask any question regarding you might have, more than looking forward to help.

/cheers

jordansissel commented 9 years ago

I don't know much about influxdb, but the proposed change looks ok - code and idea +1. Haven't tested.

elasticsearch-release commented 8 years ago

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

purbon commented 8 years ago

@albanf still looking for some test for this change, can you provide them? if not, I can help you somehow, but like @jordansissel I have no knowledge of influxdb, so would require some external help, but certanly can help with rspec knowhow :+1:

suyograo commented 8 years ago

Fixed in #30 and #29