search

logstash-plugins / logstash-output-influxdb

Apache License 2.0
58 stars 79 forks source link

Add missing documentation for send_as_tags #80

Closed jklare closed 6 years ago

jklare commented 6 years ago

The inline documentation for the code states that tags are only send if they are also defined in data_points, this part is missing here. (merged in #38)

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

jklare commented 6 years ago

looks like the build failure is not related to my patch

elasticsearch-bot commented 6 years ago

karen.metts merged this into the following branches!

Branch Commits
master c751614e1c76e58c8b93cb975d724eb4b7243ecb, 49589007c1252d3114c688a6d11cb56537bd6db3
karenzone commented 6 years ago

@jklare I have merged your changes. Thank you for contributing to Logstash.

I will create a follow up PR to bump the changelog and gemspec version to trigger the doc build to pick up your changes. I’ll reference the PR here so that you can have an example in case you would like to bump versions next time you contribute. If you choose not to, I'm always happy to bump versions for you.